Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ROW.Reset in EraseInDisplay instead of printing millions of spaces per line #2197

Merged
merged 1 commit into from
Aug 1, 2019
Merged

Use ROW.Reset in EraseInDisplay instead of printing millions of spaces per line #2197

merged 1 commit into from
Aug 1, 2019

Conversation

PankajBhojwani
Copy link
Contributor

Summary of the Pull Request

EraseScrollback no longer hangs

References

PR Checklist

  • Closes Windows Terminal hangs when erasing scrollback #2180
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@DHowett-MSFT DHowett-MSFT changed the title ED fix. Fix a hang in EraseInDisplay Aug 1, 2019
@DHowett-MSFT DHowett-MSFT changed the title Fix a hang in EraseInDisplay Use ROW.Reset in EraseInDisplay instead of printing millions of spaces per line Aug 1, 2019
@DHowett-MSFT
Copy link
Contributor

I manipulated the title a little bit :)

@PankajBhojwani PankajBhojwani merged commit 0da13cd into microsoft:master Aug 1, 2019
@PankajBhojwani PankajBhojwani deleted the ed_fix_only branch August 1, 2019 20:19
miniksa pushed a commit that referenced this pull request Aug 1, 2019
@miniksa
Use ROW.Reset in EraseInDisplay instead of printing millions of space…
2096fa5 
…s per line #2197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@DHowett-MSFT DHowett-MSFT DHowett-MSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows Terminal hangs when erasing scrollback
3 participants
@PankajBhojwani @DHowett-MSFT @zadjii-msft